New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestCodeFormat should not expect location of "tox.ini" to be in cython_dir #2700

Closed
oleksandr-pavlyk opened this Issue Nov 5, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@oleksandr-pavlyk
Contributor

oleksandr-pavlyk commented Nov 5, 2018

TestCodeFormat expects to find config file "tox.ini" in cython directory, see runtests.py#L1585.

Because "tox.ini" is not installed into site-packages, hence if one wants to test installed Cython, one must copy "tox.ini" into installation folder, or exclude style checks.

It makes sense to tie the location of "tox.ini" to the location of runtests.py instead.

This issue is meant to probe community's opinion on the proposed change. I will submit a PR if the proposed change is deemed appropriate.

@oleksandr-pavlyk

This comment has been minimized.

Contributor

oleksandr-pavlyk commented Nov 12, 2018

This is now resolved. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment