Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid GCC diagnostic pragma if GCC < 4.6 #2838

Closed
manselmi opened this issue Feb 12, 2019 · 0 comments · Fixed by #2839
Closed

Avoid GCC diagnostic pragma if GCC < 4.6 #2838

manselmi opened this issue Feb 12, 2019 · 0 comments · Fixed by #2839

Comments

@manselmi
Copy link
Contributor

manselmi commented Feb 12, 2019

Cython 0.29.5 includes 7c37790 which suppresses a warning via GCC diagnostic pragmas. However, since GCC introduced support for diagnostic pragmas in GCC 4.6, the presence of these pragmas leads to compilation errors on RHEL/CentOS 6 when using the default GCC 4.4.x compiler.

Please consider only using GCC diagnostic pragmas if GCC ≥ 4.6 so that Cython may continue to be used on RHEL/CentOS 6 systems.

I'll submit a PR shortly, but please be aware I haven't written a line of C code in over 5 years. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants