Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C compiler warning from calling __Pyx_PyFunction_FastCallDict() #3028

Closed
Kamekameha opened this issue Jul 3, 2019 · 2 comments
Closed

C compiler warning from calling __Pyx_PyFunction_FastCallDict() #3028

Kamekameha opened this issue Jul 3, 2019 · 2 comments

Comments

@Kamekameha
Copy link
Contributor

Calls to __Pyx_PyFunction_FastCallDict() apparently assume that it expects a nargs of type Py_ssize_t but currently the function expects an int, causing compilation warnings.

@scoder scoder added this to the 3.0 milestone Jul 4, 2019
@scoder scoder closed this as completed in e1de7e4 Jul 4, 2019
@scoder
Copy link
Contributor

scoder commented Jul 4, 2019

Thanks for the report.

@Kamekameha
Copy link
Contributor Author

Following this up I've found the warning is still persistent, as it so happens that PyEval_EvalCodeEx() also expects an int for the argcount argument. I've noticed also that the surrounding arguments for the call are cast down to int, so maybe the fix is as simple as casting down nargs as well.

@scoder scoder modified the milestones: 3.0, 0.29.12 Jul 5, 2019
scoder added a commit that referenced this issue Jul 5, 2019
…y_ssize_t -> int) when calling a helper function.

Closes GH-3028.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants