Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor @property on C #3107

Open
mattip opened this issue Aug 28, 2019 · 0 comments

Comments

@mattip
Copy link
Contributor

commented Aug 28, 2019

In PR #2460 and #3095 we added support for a @Property decorator on CFuncDefNodes. The support is a bit of a hack (see this discussion): the CFuncDefNode gained a is_cgetter property and that property is checked when determining the type in compute_c_result_type, calculate_result_node and more. It would be better to somehow

  • make the support more systematic rather than having type checks scattered through the code
  • also support @property.setter decorators and maybe others

I am not sure how to go about it. What does the suggestion to " make them an inline node" mean? Is this a new node type?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.