Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging: provide ManyLinux2014 packages #3354

Open
penguinolog opened this issue Feb 12, 2020 · 4 comments
Open

Packaging: provide ManyLinux2014 packages #3354

penguinolog opened this issue Feb 12, 2020 · 4 comments

Comments

@penguinolog
Copy link

@penguinolog penguinolog commented Feb 12, 2020

At this moment manylinux1 packages are providden, but in case of package build on non-x86 platforms it require to rebuild cython (and it cost time).
For now it possible to build manylinux2010 and manylinux1 automatically in manylinux2010 image (no any script changes, except image name) and separately manylinux2014 (several platforms) on CI.
Idea: build as minium aarch64 due to it popularity.

@mattip

This comment has been minimized.

Copy link
Contributor

@mattip mattip commented Feb 12, 2020

The wheels are built via the github.com://MacPython/cython-wheels repo. For NumPy I am currently working on a similar request MacPython/numpy-wheels#70. Once that one is in, cython can decide if it wants to do something similar. It would also be nice to provide pypy manylinux2010/win32/macOS wheels as well.

penguinolog added a commit to penguinolog/cython that referenced this issue Feb 13, 2020
@scoder

This comment has been minimized.

Copy link
Contributor

@scoder scoder commented Feb 13, 2020

I actually wonder if we shouldn't just upload a single (non-binary) universal py2/3 Python wheel in addition to the current binary wheels for Mac/Linux/Windows, instead of investing more build time into binary wheels for less common platforms. I never tried that, but would expect that pip simply prefers the binary wheel if it finds one, and otherwise falls back to downloading the Python-only wheel, before it tries a source build.

For the most common use case of a one-time package build of just a few Cython modules (e.g. in CI), this will still be hugely faster than additionally compiling Cython first, before even starting with the user provided sources. On most systems, the C/C++ compilation time largely dominates the actual Cython runs, so using a Python-only Cython wheel would only be slightly slower than a binary wheel most of the time.

scoder added a commit that referenced this issue Feb 13, 2020
@scoder

This comment has been minimized.

Copy link
Contributor

@scoder scoder commented Feb 13, 2020

I've uploaded a py2.py3-any wheel for 0.29.15. Let's see if anyone complains.

@mattip

This comment has been minimized.

Copy link
Contributor

@mattip mattip commented Feb 13, 2020

PyPy applauds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.