New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MemoryView implementation incompatible with Options.cache_builtins = False #3406
Comments
Now they make their own tiny cache of the relevant exceptions at module initialization so they can still access these without the GIL. closes cython#3406
I've done this a tiny bit differently to how you've suggested, since I think the whole point of |
Great, thanks for the quick turnaround! Your way will prevent someone from mocking |
I was just adding a comment to that effect in the PR description when you replied:
I think the "implementation detail" excuse makes it OK but we'll see if it makes it past review... |
Now they make their own tiny cache of the relevant exceptions at module initialization so they can still access these without the GIL. closes #3406
Disabling the
cache_builtins
option in setup.py:causes code that uses
MemoryView
to fail to compile:(There are several such errors building the file, all stemming from doing a lookup on the exception type without the GIL held.)
To fix this, the GIL should be locked before calling _err_dim.
The text was updated successfully, but these errors were encountered: