Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible regression between 0.29.15 and 0.29.16 #3543

Closed
t-bltg opened this issue Apr 23, 2020 · 2 comments
Closed

Possible regression between 0.29.15 and 0.29.16 #3543

t-bltg opened this issue Apr 23, 2020 · 2 comments

Comments

@t-bltg
Copy link

t-bltg commented Apr 23, 2020

I would like to open a possible regression between releases 0.29.15 and 0.29.16.

Please see symengine/symengine.py#318 for the full description (missing a typedef struct __pyx_ctuple_long ... in the generated cpp source).

I think that the regression was introduced in #3271 (@isotherm ?):
applying https://github.com/cython/cython/pull/3271.patch on the 0.29.15 release results in the same build error as when using 0.29.16.

@t-bltg t-bltg changed the title Possible between 0.29.15 and 0.29.16 Possible regression between 0.29.15 and 0.29.16 Apr 23, 2020
@scoder scoder added this to the 0.29.17 milestone Apr 25, 2020
scoder pushed a commit that referenced this issue Apr 25, 2020
generate_type_definitions maintained a list of ctuples for which code
was already generated, but the logic did not match the logic used in
generate_type_header_code, which does not generate code if the entry is
marked as unused.

If the first ctuple of a certain type was marked unused, but later
instances were not, this could result in no code being generated for
the ctuple at all. Resolve by verifying whether the ctuple entry is used
before adding it to the list.

Co-authored-by: Kirk Meyer <kirk.meyer@ravenind.com>
scoder pushed a commit that referenced this issue Apr 25, 2020
generate_type_definitions maintained a list of ctuples for which code
was already generated, but the logic did not match the logic used in
generate_type_header_code, which does not generate code if the entry is
marked as unused.

If the first ctuple of a certain type was marked unused, but later
instances were not, this could result in no code being generated for
the ctuple at all. Resolve by verifying whether the ctuple entry is used
before adding it to the list.

Co-authored-by: Kirk Meyer <kirk.meyer@ravenind.com>
@scoder
Copy link
Contributor

scoder commented Apr 25, 2020

Resolved by #3551 in 9e26b37.

@scoder scoder closed this as completed Apr 25, 2020
@t-bltg
Copy link
Author

t-bltg commented Apr 25, 2020

Confirmed, thanks for the quick fix !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants