Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M_PI: undeclared identifier, after 0.29.18 #3622

Closed
sciunto opened this issue May 20, 2020 · 3 comments
Closed

M_PI: undeclared identifier, after 0.29.18 #3622

sciunto opened this issue May 20, 2020 · 3 comments

Comments

@sciunto
Copy link

sciunto commented May 20, 2020

In scikit image, it appears that after the release of cython 0.29.18, a failure appeared

skimage\restoration\_unwrap_1d.c(2215): error C2065: 'M_PI': undeclared identifier

Our incriminated file: https://github.com/scikit-image/scikit-image/blob/master/skimage/restoration/_unwrap_1d.pyx
Our issue: scikit-image/scikit-image#4727
Our CI failure: https://ci.appveyor.com/project/scikit-image/scikit-image/builds/32990701/job/6oxfs51ij6fk6jqi#L840

Do you have any idea on how to fix this? Is it a bug from your or our side?

(Cc @emmanuelle)

@da-woods
Copy link
Contributor

I'd guess 399a72d didn't get merged into 0.29.18?

@scoder
Copy link
Contributor

scoder commented May 20, 2020

I'd guess 399a72d didn't get merged into 0.29.18?

Oh, well. Yeah, sorry for that. I'll release a 0.29.19 with that fix then (4ca10b5).

@scoder scoder closed this as completed May 20, 2020
@emmanuelle
Copy link

Thank you so much for the help @scoder and @da-woods :-) ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants