Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPy3: make special dict methods work #1631

Merged
merged 2 commits into from Mar 18, 2017
Merged

PyPy3: make special dict methods work #1631

merged 2 commits into from Mar 18, 2017

Conversation

arigo
Copy link

@arigo arigo commented Mar 15, 2017

The .iterkeys(), .itervalues() and .iteritems() methods are accepted in Cython
even when targetting Python 3.x. However, this is implemented by a shortcut
inside Optimize.c that is explicitly disabled on PyPy. This fixes the
situation.

The .iterkeys(), .itervalues() and .iteritems() methods are accepted in Cython
even when targetting Python 3.x.  However, this is implemented by a shortcut
inside Optimize.c that is explicitly disabled on PyPy.  This fixes the
situation.
@mattip
Copy link
Contributor

mattip commented Mar 16, 2017

I do not understand how the failure (on cpython3.2 c backend only) are connected to this commit, are the tests there flaky at all?

@scoder
Copy link
Contributor

scoder commented Mar 18, 2017

Thanks!
The failures are unrelated to this change.

@scoder scoder merged commit c83255e into cython:master Mar 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants