Now uses specialised functions for complex abs #1648
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This patch avoids
abs(a_complex_number)
casting the complex number back to a Python object and instead uses the__pyx_c_abs*
functions that are already defined. It also modifies the specialization forabs
on int and long to not require the GIL.Also added a test case to confirm it's working
Notes:
(but it should be loaded by the complex data types hopefully)
This might be worth someone double checking
(but this is a minor improvement to existing code)