New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not apply decorators twice #1724

Merged
merged 1 commit into from Jun 25, 2017

Conversation

Projects
None yet
2 participants
@jdemeyer
Contributor

jdemeyer commented Jun 2, 2017

When calling chain_decorators(node, ...), set node.decorators = None to avoid calling the decorators twice.

This fixes #1679

@scoder

This comment has been minimized.

Show comment
Hide comment
@scoder

scoder Jun 25, 2017

Contributor

I'm not entirely sure that this is going to be the final fix in the light of #1434, but that issue is probably non-trivial and this solves the problem at hand. Thanks!

Contributor

scoder commented Jun 25, 2017

I'm not entirely sure that this is going to be the final fix in the light of #1434, but that issue is probably non-trivial and this solves the problem at hand. Thanks!

@scoder scoder merged commit 84c37f4 into cython:master Jun 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jdemeyer

This comment has been minimized.

Show comment
Hide comment
@jdemeyer

jdemeyer Jun 26, 2017

Contributor

I'm not entirely sure that this is going to be the final fix in the light of #1434

There are certainly more bugs related to decorators. In general, the Cython code to deal with decorators is quite complex. It would certainly be a good idea to rethink/refactor decorators in general.

But this PR does fix one specific (and serious) issue. Thanks for merging.

Contributor

jdemeyer commented Jun 26, 2017

I'm not entirely sure that this is going to be the final fix in the light of #1434

There are certainly more bugs related to decorators. In general, the Cython code to deal with decorators is quite complex. It would certainly be a good idea to rethink/refactor decorators in general.

But this PR does fix one specific (and serious) issue. Thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment