Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type inference for Pythran expressions #1954

merged 7 commits into from Oct 28, 2017


Copy link

@nils-braun nils-braun commented Oct 28, 2017

In the moment, the pythran objects get converted into "normal" python objects in the last assignment in each line and copied back into pythran when used in the next line.

This PR fixes this by:

  • adding pythran objects to the safe objects
  • adding support for pythran in cmp and index during type interference
  • added proper support for pythran in assignments

This was done during a sprint together with @scoder.

On a small benchmark on one of the numpy_pythran tests, a speed improvement of ~15% could be achieved (but this was just a small test).

@scoder scoder changed the title Added support for pythran with multiple line numpy funcitions Type inference for Pythran expressions Oct 28, 2017
Copy link

scoder commented Oct 28, 2017


@scoder scoder merged commit 12eaff0 into cython:master Oct 28, 2017
@scoder scoder added this to the 0.28 milestone Oct 28, 2017
Copy link
Contributor Author

Ups, it seems I have not uploaded the changes we discussed during the code review to the branch before you merged it :-( Thanks for fixing it!

@nils-braun nils-braun deleted the pythran-multiple-line-support branch October 29, 2017 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants