Type inference for Pythran expressions #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_type_code, as this is needed during type interference
scoder
changed the title
|
Thanks! |
|
Ups, it seems I have not uploaded the changes we discussed during the code review to the branch before you merged it :-( Thanks for fixing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the moment, the pythran objects get converted into "normal" python objects in the last assignment in each line and copied back into pythran when used in the next line.
This PR fixes this by:
This was done during a sprint together with @scoder.
On a small benchmark on one of the numpy_pythran tests, a speed improvement of ~15% could be achieved (but this was just a small test).