Fix importing of namespace packages. Add in a regtest for the same. #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can exclude the test in |
…mespace packages were introduced in Python 3.3.
|
This is a fantastic PR, thanks so much. Any estimation on when this will be released on PyPI, either as a bugfix release for 0.28 or as part of 0.29? |
|
Probably a couple of weeks still, in 0.29. |
|
Good to know, thanks for the information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.3 added in support for namespace packages which are essentially directories with no
__init__.pyfile. This pull request adds in support for these into pyximport.On python2 trying to import a pyx module in a namespace package is still an error (which matches normal python behavior).
Note that the regtest only works on python3. Not sure how to adjust it for python2 but happy to update this pr if somebody can point me in the right direction...
-- PG