Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NPY_CASTING #2523

Merged
merged 1 commit into from Aug 11, 2018
Merged

Add NPY_CASTING #2523

merged 1 commit into from Aug 11, 2018

Conversation

jakirkham
Copy link
Contributor

Include NPY_CASTING along with the other things externed from numpy/arrayobject.h.

Include `NPY_CASTING` along with the other things `extern`ed from
`numpy/arrayobject.h`.
@jakirkham
Copy link
Contributor Author

Thoughts on this?

@jakirkham
Copy link
Contributor Author

@scoder, could you please review this when you have a chance?

@scoder
Copy link
Contributor

scoder commented Aug 4, 2018

Looks good, no problem there. But would be nice to have a tiny bit of usage in the numpy tests to at least see if this compiles correctly.

@jakirkham
Copy link
Contributor Author

Given this is forward declaring an enum in Cython, how would you propose we test this? FWIW looked at some neighboring forward declaration code, but wasn't able to find tests for them.

@scoder
Copy link
Contributor

scoder commented Aug 7, 2018

I don't see any second declaration, so this is not forward declaring anything, it's the real thing. Just use them somewhere in a numpy test, for what doesn't really matter. I just want the result of the Cython declarations to pass through a C compiler.

@scoder scoder merged commit 92481c2 into cython:master Aug 11, 2018
@scoder scoder added this to the 0.29 milestone Aug 11, 2018
@jakirkham jakirkham deleted the add_NPY_CASTING branch August 15, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants