ENH: add no-capture option to runtests to allow debugging srctree tests #2701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertwb
reviewed
Nov 6, 2018
runtests.py
Outdated
| @@ -2118,6 +2132,9 @@ def main(): | |||
| if options.xml_output_dir: | |||
| shutil.rmtree(options.xml_output_dir, ignore_errors=True) | |||
|
|
|||
| interval = 10 | |||
| if not options.capture: | |||
| interval = 10000 | |||
There was a problem hiding this comment.
Perhaps set this to None and modify time_stamper_thread to return an empty context in that case?
runtests.py
Outdated
| @@ -2118,6 +2132,9 @@ def main(): | |||
| if options.xml_output_dir: | |||
| shutil.rmtree(options.xml_output_dir, ignore_errors=True) | |||
|
|
|||
| interval = 10 | |||
There was a problem hiding this comment.
Style nit: it'd be cleaner to not re-assign (and perhaps name this something less generic).
|
also added to |
4 tasks
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running srctree tests, they run under a separate process. It is sometimes convenient to add a
import pdb;pdb.set_trace()breakpoint inside one of these tests to debug what is going on, but the test runner captures stdout and stderr so the interactive prompt is swallowed. Add ano-captureoption torunteststo allow the subtree tests to run without capturing stdout, stderr.If capturing is off, also increase the
time_stamper_threadinterval to prevent printing logging messages while debugging.