BUG: Fix reference count issues #3022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberg
force-pushed
the
getitem_refcnt
branch
3 times, most recently
from
43d5b85
to
4f50113
Compare
The new PyInt_FromSsize_t reference was not decref'ed in general.
|
Sorry for the many forced pushs (did not run tests, which I guess would have told me that my code looked weird) and adding of more commits as I am on to a few other things. If you want me to split it up or do style fixes, etc. I am happy to do that. Until then, may push more small things as I track them down. |
seberg
changed the title
|
OK, this together with gh-3023 makes the numpy random tests run through cleanly with respect to refcounting issues, so for me this has settled already. |
scoder
reviewed
Jun 29, 2019
Cython/Utility/ObjectHandling.c
Outdated
| @@ -497,8 +500,12 @@ static CYTHON_INLINE int __Pyx_SetItemInt_Fast(PyObject *o, Py_ssize_t i, PyObje | |||
| PyMappingMethods *mm = Py_TYPE(o)->tp_as_mapping; | |||
| PySequenceMethods *sm = Py_TYPE(o)->tp_as_sequence; | |||
| if (mm && mm->mp_ass_subscript) { | |||
| int r | |||
scoder
reviewed
Jun 29, 2019
Cython/Utility/ObjectHandling.c
Outdated
| @@ -432,8 +432,11 @@ static CYTHON_INLINE PyObject *__Pyx_GetItemInt_Fast(PyObject *o, Py_ssize_t i, | |||
| PyMappingMethods *mm = Py_TYPE(o)->tp_as_mapping; | |||
| PySequenceMethods *sm = Py_TYPE(o)->tp_as_sequence; | |||
| if (mm && mm->mp_subscript) { | |||
| PyObject *key = PyInt_FromSsize_t(i); | |||
| return likely(key) ? mm->mp_subscript(o, key) : NULL; | |||
| PyObject r, *key = PyInt_FromSsize_t(i); | |||
There was a problem hiding this comment.
Heh, thanks... worst fixup ever
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new PyInt_FromSsize_t reference was not decref'ed in general.
I was hacking on numpy using
pytest-leaksand ran into a reference issues within cython (numpy.random). This is the on that I managed to track down for now. There is another coming up (although most likely I will only open an issue).I suppose these should get tests? Just ping me, and I will look into it.