Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --parallel support in build_ext.build_extensions() #3187

Merged
merged 1 commit into from Oct 18, 2019

Conversation

Alphadelta14
Copy link
Contributor

In Python 3.5, distutils added a --parallel / -j option to allow extensions to be compiled in parallel. setuptools leverages this by default unless Cython is present because it uses the build_ext provided by Cython instead. Cython overrides build_extensions() entirely assuming that it just calls build_extension (which it did before Python 3.5).
This change defers back to the original build_extensions() call in build_ext after mutating the sources so that --parallel works with Cython properly.

@scoder scoder added this to the 3.0 milestone Oct 18, 2019
@scoder
Copy link
Contributor

scoder commented Oct 18, 2019

Ah, yes, makes total sense. Thanks!

@scoder scoder merged commit 01e00f6 into cython:master Oct 18, 2019
@Alphadelta14 Alphadelta14 deleted the alphadelta14/build-ext-parallel branch October 18, 2019 10:17
@scoder scoder modified the milestones: 3.0, 0.29.14 Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants