Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pythran update: __builtin__ -> builtins #3308

Merged
merged 1 commit into from Mar 21, 2020
Merged

Pythran update: __builtin__ -> builtins #3308

merged 1 commit into from Mar 21, 2020

Conversation

serge-sans-paille
Copy link
Contributor

No description provided.

@serge-sans-paille
Copy link
Contributor Author

@scoder can you consider merging this one? This PR is required to keep cython and pythran in sync.

scoder
scoder reviewed Mar 20, 2020
View reviewed changes
Copy link
Contributor

@scoder scoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually looks like it could go into 0.29.x, right?

Cython/Compiler/Pythran.py Outdated Show resolved Hide resolved
@scoder scoder added this to the 0.29.16 milestone Mar 20, 2020
@serge-sans-paille
Copy link
Contributor Author

Thanks for the review o/

@serge-sans-paille
Copy link
Contributor Author

And yeah it could go to 0.29.x

@scoder scoder added the Pythran label Mar 21, 2020
@scoder scoder merged commit 97d6310 into cython:master Mar 21, 2020
scoder pushed a commit that referenced this pull request Mar 21, 2020
@serge-sans-paille @scoder
Adapt to Pythran update: __builtin__ -> builtins (GH-3308)
d05e8bb
@serge-sans-paille
Copy link
Contributor Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scoder scoder scoder left review comments

Assignees
No one assigned
Labels
Pythran
Projects
None yet
Milestone
0.29.16
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@serge-sans-paille @scoder