Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial #3354 - build manylinux2010 #3355

Merged
merged 1 commit into from Apr 9, 2020
Merged

Partial #3354 - build manylinux2010 #3355

merged 1 commit into from Apr 9, 2020

Conversation

penguinolog
Copy link
Contributor

Use manylinx2010 images to build manylinux1 and manylinux2010 at the same time.

@McSinyx
Copy link
Contributor

McSinyx commented Feb 13, 2020

Just curius, how is that possible with such simple change? I'm currently using cibuildwheel for my personal project but want to know how things work.

@penguinolog
Copy link
Contributor Author

Manylinux2010 is not so far from manylinux1, so manylinux2010 for compatibility reasons also making manylinux1 wheels.
Manylinux2014 is different: it Centos 7 based and have different versions of system libraries, so it not able to build wheels for old systems.

@scoder
Copy link
Contributor

scoder commented Feb 13, 2020

Works for me, but doesn't seem to have a benefit for now. It just doubles the number of generated "manylinux" wheels.

@penguinolog
Copy link
Contributor Author

penguinolog commented Feb 13, 2020

technically manylinux2010 uses newer libraries (centos6 instead of centos5), old name is served for old pip compatibility reasons.
Centos5 is already "dead", so manylinux2010 is more actual.

@scoder scoder added this to the 3.0 milestone Apr 9, 2020
@scoder scoder merged commit b5b314c into cython:master Apr 9, 2020
@scoder
Copy link
Contributor

scoder commented Apr 9, 2020

Thanks for bringing this in. I think it's good to make the switch to at least the somewhat newer 2010 wheels.

@penguinolog penguinolog deleted the manylinux2010 branch April 9, 2020 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants