Marks view.* extension types as imported #3413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that they can be inherited from. Closes cython#3396
scoder
reviewed
Mar 21, 2020
Cython/Compiler/CythonScope.py
Outdated
Comment on lines
135
to
138
| for mod in self.context.modules.values(): | ||
| if mod is self or mod.is_builtin_scope: | ||
| continue | ||
| mod.types_imported.update(ext_types) |
There was a problem hiding this comment.
Hmm, this doesn't quite feel right at first sight. Why should we add the internal types to the imported types of all user defined modules? Shouldn't that happen only (and automatically) when a user cimports cython.view?
There was a problem hiding this comment.
I've updated it with a different approach. I can't really work out where it'd be sensible detect that these types are being used and add them to types_imported so I've marked them with a flag so they don't get imported instead..
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that they can be inherited from.
Closes #3396