Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup more generator temps #3522

Merged
merged 3 commits into from Apr 17, 2020
Merged

Cleanup more generator temps #3522

merged 3 commits into from Apr 17, 2020

Conversation

da-woods
Copy link
Contributor

Follows up #3517

  1. Actually fixes Generator Function with Yield in condition causes maybe-uninitialized warning with GCC #3430 by handling non-Python types correctly.
  2. Fixes another uninitialized temp error that was appearing in the test generators_py

I'm struggling to see how to add tests for these unfortunately. I'm not sure if werror catches C compilation warnings, but the Cython code seems to create enough low-level warnings that it isn't usable anyway.

I'd missed this case in the initial go
Was causing warnings in generators_py
@scoder
Copy link
Contributor

scoder commented Apr 15, 2020

It's difficult to make assertions on C warnings, given that different C compilers do different things here. At least gcc (and clang?) would be happy to receive a -Werror flag to fail on warnings. See #3482.

@scoder scoder added this to the 3.0 milestone Apr 15, 2020
@scoder scoder added the defect label Apr 15, 2020
@scoder scoder modified the milestones: 3.0, 0.29.17 Apr 15, 2020
Since the temps survived into the result_code
@scoder scoder merged commit 8db370d into cython:master Apr 17, 2020
scoder added a commit that referenced this pull request Apr 17, 2020
* Fixed indexing temps for non-python objects.
* Moved cleanup into release_temps since the temps survived into the result_code.
@da-woods da-woods deleted the cleanup_temps2 branch April 17, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generator Function with Yield in condition causes maybe-uninitialized warning with GCC
2 participants