Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

classmethod should fallback to always calling PyClassMethod_New #3660

Merged
merged 1 commit into from Jun 2, 2020
Merged

classmethod should fallback to always calling PyClassMethod_New #3660

merged 1 commit into from Jun 2, 2020

Conversation

da-woods
Copy link
Contributor

@da-woods da-woods commented Jun 2, 2020

...instead of deciding for itself that the type is invalid

Fixes #3658

@da-woods
classmethod should fallback to calling PyClassMethod_New
13a759f 
Instead of deciding for itself that the type is
invalid
@scoder scoder added this to the 3.0 milestone Jun 2, 2020
@scoder scoder merged commit 12ab8bc into cython:master Jun 2, 2020
@scoder
Copy link
Contributor

scoder commented Jun 2, 2020

Thanks, yeah, that seems right.

@da-woods da-woods deleted the classmethodfix branch June 2, 2020 19:08
@scoder scoder modified the milestones: 3.0, 0.29.20 Jun 4, 2020
scoder pushed a commit that referenced this pull request Jun 4, 2020
@da-woods @scoder
classmethod() should fall back to calling PyClassMethod_New() instead…
7604895 
… of deciding for itself that the type is invalid. (GH-3660)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
defect Python Semantics
Projects
None yet
Milestone
0.29.20
Development

Successfully merging this pull request may close these issues.

TypeError: Class-level classmethod() can only be called on a method_descriptor or instance method
2 participants
@da-woods @scoder