Only #define PY_SSIZE_T_CLEAN if it is not already #defined #4104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew V. Jones <andrew.jones@vector.com>
aytey
force-pushed
the
conditional_ssize_t_clean
branch
from
ce8a1c9
to
3ccd947
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For something I use Cython for, we do not use
setup.pyor anything like that, but add the output of Cython (i.e., the .c files) to our CMakeLists.txt.However, for the rest of the code in our project, we already have
PY_SSIZE_T_CLEANset as a compile-time define (e.g., withadd_definitions(-DPY_SSIZE_T_CLEAN). This causes us an issue when we're compiling the output of Cython, as we get a warning (which becomes an error with-Werror) related toPY_SSIZE_T_CLEAN.This PR changes Cython such that
PY_SSIZE_T_CLEANis only defined in the Cython-generated code, if it is not already defined.Signed-off-by: Andrew V. Jones andrew.jones@vector.com