Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

silence unused warnings in universal way #4162

Merged
merged 2 commits into from May 15, 2021
Merged

silence unused warnings in universal way #4162

merged 2 commits into from May 15, 2021

Conversation

maxbachmann
Copy link
Contributor

This implements the changes from #4149 that do not involve the code generation, so the review of those changes gets simpler.

@scoder
Copy link
Contributor

scoder commented May 14, 2021

Looks good to me.

Did you look for cases where CYTHON_MAYBE_UNUSED_VAR() would be more appropriate due to preprocessor conditions?

@maxbachmann
Copy link
Contributor Author

Did you look for cases where CYTHON_MAYBE_UNUSED_VAR() would be more appropriate due to preprocessor conditions?

Updated the usage when it is more appropriate.

scoder
scoder reviewed May 15, 2021
View reviewed changes
Cython/Utility/ModuleSetupCode.c Outdated Show resolved Hide resolved
Cython/Utility/StringTools.c Outdated Show resolved Hide resolved
@scoder scoder merged commit c79ae55 into cython:master May 15, 2021
@scoder
Copy link
Contributor

scoder commented May 15, 2021

Thanks

@scoder scoder added this to the 3.0 milestone May 15, 2021
@scoder scoder mentioned this pull request May 24, 2021
Closed
@mattip mattip mentioned this pull request Mar 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scoder scoder scoder left review comments

Assignees
No one assigned
Labels
Code Generation defect
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxbachmann @scoder