Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix move on msvc #4191

Merged
merged 2 commits into from May 23, 2021
Merged

fix move on msvc #4191

merged 2 commits into from May 23, 2021

Conversation

maxbachmann
Copy link
Contributor

@maxbachmann maxbachmann commented May 23, 2021

@scoder this works around the broken __cplusplus macro in msvc (https://devblogs.microsoft.com/cppblog/msvc-now-correctly-reports-__cplusplus/)

The same issue was fixed for the __PYX_STD_MOVE_IF_SUPPORTED macro here: #3792

@scoder
Copy link
Contributor

scoder commented May 23, 2021

Looks good.

I wonder if the namespace should be prefixed by __pyx_, BTW.

@scoder scoder added this to the 3.0 milestone May 23, 2021
@scoder scoder merged commit 30f7228 into cython:master May 23, 2021
@phoerious
Copy link
Contributor

Could you backport this patch to 0.29? My CI keeps failing if I don't provide a custom pxd file.

@scoder
Copy link
Contributor

scoder commented Nov 18, 2021

Qualifies and seems to apply cleanly.
41d65a7

@phoerious
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants