Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warnings about constant expressions on MSVC #4317

Merged
merged 3 commits into from
Aug 7, 2021

Conversation

da-woods
Copy link
Contributor

@da-woods da-woods commented Jul 28, 2021

Adds utility code sections designed to be able to toggle warnings for the duration of the utility code.

Hopefully supersedes #4165

@maxbachmann Opinions? Does this achieve what you want? (I need to reboot to get to MSVC so it isn't quick for me to test)

Adds utility code sections designed to be able to toggle
warns for the duration of the utility code
Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@maxbachmann
Copy link
Contributor

@da-woods This successfully suppresses the warning for the utility code 👍
Note that the warning still occurs in some other places, but this solves the biggest part.

@scoder scoder merged commit 563c261 into cython:master Aug 7, 2021
@da-woods da-woods deleted the constant-conditionals branch August 7, 2021 08:09
@scoder
Copy link
Contributor

scoder commented Aug 7, 2021

Thanks @da-woods and @maxbachmann for bringing up good ideas and solutions for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants