Changes needed to begin testing GraalPython #4328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very little works at present, there looks to be huge memory-leaks, and the test-suite runs very slowly. It definitely isn't worth adding anything on Github Actions at this stage. It's just designed to get over the initial hurdle so that it can be tested and improvements can be made if anyone is inlined.
da-woods
commented
Aug 8, 2021
Cython/Utility/ModuleSetupCode.c
Outdated
Comment on lines
113
to
114
| /* For very preliminary testing purposes. Most variables are set the same as PyPy. | ||
| The existence of this section does not imply that anything works or is even tested */ |
There was a problem hiding this comment.
This comment is deliberately written so that it doesn't get filtered out and it appears in the generated C. Just to discourage people from thinking that it's "supported"
Bluenix2
reviewed
Sep 8, 2021
fangerer
reviewed
Sep 22, 2021
|
Hi, is there any view to merging this? |
fangerer
approved these changes
Dec 16, 2021
Co-authored-by: Bluenix <bluenixdev@gmail.com>
|
Simple enough to be included, and gets some stuff working. Sure, let's get it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very little works at present, there looks to be huge memory-leaks,
and the test-suite runs very slowly. It definitely isn't worth adding
anything on Github Actions at this stage.
It's just designed to get over the initial hurdle so that it
can be tested and improvements can be made if anyone is
inclined.
Related to #4123