Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not redefine _USE_MATH_DEFINES in generated code #4690

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

georgthegreat
Copy link
Contributor

We unconditionally add /D_USE_MATH_DEFINES via cmdline and doing this triggers -Wmacro-redefined in cython-generated code.

We unconditionally add `/D_USE_MATH_DEFINES` via cmdline and doing this triggers `-Wmacro-redefined` in cython-generated code.
@scoder
Copy link
Contributor

scoder commented Mar 21, 2022

Sure, thanks.

@scoder scoder merged commit a1b6dae into cython:master Mar 21, 2022
scoder pushed a commit that referenced this pull request Mar 21, 2022
Unconditionally adding `/D_USE_MATH_DEFINES` via cmdline triggers `-Wmacro-redefined` in cython-generated code.
@scoder
Copy link
Contributor

scoder commented Mar 21, 2022

Backported to 0.29.x in ef14c14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants