Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector and list with two template parameters #471

Closed
wants to merge 4 commits into from
Closed

Vector and list with two template parameters #471

wants to merge 4 commits into from

Conversation

molpopgen
Copy link
Contributor

Rationale:

  • STL containers take a type and an allocator as template params
  • Current .pxd files rely on the default allocator
  • There are better-performing allocators out there (boost, Intel's TBB library, etc.)
  • These new .pxd files seem to be the "best we can do" as Cython doesn't support template type parameter defaults.

The downside is that cimports need to be careful about name conflicts, but "cimport x as y" solves that.

@robertwb
Copy link
Contributor

How about building on top of 767fce8

@molpopgen
Copy link
Contributor Author

I'm going to close this PR and open a new one, starting clean from current Cython master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants