Extract __Pyx_PyMethodDescr_Check
#5225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da-woods
reviewed
Jan 24, 2023
|
According to the build logs, there's a mismatch in braces. |
0dminnimda
commented
Feb 20, 2023
Cython/Utility/ObjectHandling.c
Outdated
| @@ -2063,6 +2039,13 @@ static int __Pyx_TryUnpackUnboundCMethod(__Pyx_CachedCFunction* target) { | |||
| target->method = unbound_method; | |||
| } | |||
| } | |||
| #if CYTHON_COMPILING_IN_CPYTHON | |||
There was a problem hiding this comment.
I am a little bit confused about whether this should remain in the code or not
scoder
reviewed
May 23, 2023
| // PyMethodDescr_Type is not exposed in the CPython C-API in Py2. | ||
| static PyTypeObject *methoddescr_type = NULL; | ||
| if (unlikely(methoddescr_type == NULL)) { | ||
| PyObject *meth = PyObject_GetAttrString((PyObject*)&PyList_Type, "append"); | ||
| if (unlikely(!meth)) return NULL; | ||
| if (unlikely(!meth)) return 0; |
There was a problem hiding this comment.
This would be an error case, not just false/0.
Co-authored-by: scoder <stefan_ml@behnel.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract out and use common functoin
__Pyx_PyMethodDescr_CheckDepends on #5219 - this pr should fix some changes to the problematic area