Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All of the .md hyperlinks are broken #41

Closed
hydrosquall opened this issue Jan 19, 2019 · 4 comments
Closed

All of the .md hyperlinks are broken #41

hydrosquall opened this issue Jan 19, 2019 · 4 comments

Comments

@hydrosquall
Copy link

Hi, thanks for the great work on this project! I wanted to flag an issue that I noticed when browsing the docs today.

The issue is that all the links to .md files work on on Github, but break when the page is rendered to html.

For example, click on Groups on this page in the text Most often, Groups are more functional and easier to use.

http://manual.cytoscape.org/en/stable/Nested_Networks.html

A fix could be to either update all the links from .md to HTML, or to update the script which turns the markdown files into HTML to transform all the markdown links into HTML ones.

@hydrosquall
Copy link
Author

A coworker suggested looking into using this library in the Sphinx config to help with converting the URLs correctly in a non-manual way:

https://github.com/rtfd/recommonmark

@ritwikagarwal
Copy link

I think the issue is fixed now as I can easily render all the links on html currently and correctly.
Thanks.

@hydrosquall
Copy link
Author

hydrosquall commented May 19, 2019

It looks like this was done through the good work of @khanspers - thank you :)!

(Via commits like this: 29c4cef )

I think it could still be worthwhile to see about automating this in the build step to avoid similar manual work in the future, but I'll leave it to the project maintainers to decide if this issue should be left open.

@joshtburdick
Copy link

This seems to have recurred, at least when I click on
https://manual.cytoscape.org/en/stable/Nested_Networks.html

I'm using Chrome, on Mac OS X.

(I haven't used Cytoscape much, but the documentation otherwise looks well-done.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants