New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mandatory weaver dependency on CoSE layout #1687

Closed
maxkfranz opened this Issue Jan 20, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@maxkfranz
Member

maxkfranz commented Jan 20, 2017

The cose layout is the only one with a dependency --- weaver. By removing the dependency, weaver no longer needs to be embedded. CoSE can use a small polyfill if the dev doesn't want to use Weaver threads.

This allows us to reduce the base lib size while maintaining compatibility for usecases where Cytoscape is just put in a script tag. It also allows CoSE to remain in the main lib for convenience: A force-directed layout is always available even without external extensions.

Extensions that want to use threads can require('weaver') directly.

Depends on: Extension revisions #1686

@maxkfranz maxkfranz added this to the 3.0.0 milestone Jan 20, 2017

@maxkfranz maxkfranz changed the title from Move `cose` layout to external repo to Remove mandatory weaver dependency on CoSE layout Feb 22, 2017

@maxkfranz maxkfranz closed this Feb 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment