New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for background image properties to be specified as multiples (i.e. arrays or space separated strings) #1747

Closed
maxkfranz opened this Issue Mar 9, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@maxkfranz
Member

maxkfranz commented Mar 9, 2017

To allow for multiple background images per node, the simplest solution is to make each background image style property of type multiple. Each index in the arrays corresponds to an image.

  • Change each image property type to have the multiple flag.
  • The node drawing function needs to iterate over the images.
  • This needs to be tested. There may be edge cases or race conditions with loading the images, for example.

@maxkfranz maxkfranz added this to the 3.1.0 milestone Mar 9, 2017

@maxkfranz

This comment has been minimized.

Show comment
Hide comment
@maxkfranz

maxkfranz Mar 10, 2017

Member

@mj3cheun This would be a great issue to do while I'm reviewing your extensions changes. Dylan needs it for his SBGN lib

Member

maxkfranz commented Mar 10, 2017

@mj3cheun This would be a great issue to do while I'm reviewing your extensions changes. Dylan needs it for his SBGN lib

@mj3cheun mj3cheun self-assigned this Mar 14, 2017

@mj3cheun

This comment has been minimized.

Show comment
Hide comment
@mj3cheun

mj3cheun Mar 15, 2017

Member

@maxkfranz Made PR.

Member

mj3cheun commented Mar 15, 2017

@maxkfranz Made PR.

maxkfranz added a commit that referenced this issue Mar 16, 2017

d2fong added a commit to d2fong/cytoscape.js that referenced this issue Mar 31, 2017

d2fong added a commit to d2fong/cytoscape.js that referenced this issue Mar 31, 2017

d2fong added a commit to d2fong/cytoscape.js that referenced this issue Mar 31, 2017

maxkfranz added a commit that referenced this issue Apr 18, 2017

Merge pull request #1786 from mj3cheun/1747-2
Added documentation for multiple images #1747

@maxkfranz maxkfranz closed this Apr 19, 2017

maxkfranz added a commit that referenced this issue Nov 10, 2017

Newly added elements should not have their style initially updated tw…
…ice from false background image loading detection #2016

Caused by : Allow for background image properties to be specified as multiples (i.e. arrays or space separated strings) #1747

The check for whether background images are loading is incorrect, as the count of images does not take into account invalid/null entries.

maxkfranz added a commit that referenced this issue Nov 10, 2017

Newly added elements should not have their style initially updated tw…
…ice from false background image loading detection #2016

Caused by : Allow for background image properties to be specified as multiples (i.e. arrays or space separated strings) #1747

The check for whether background images are loading is incorrect, as the count of images does not take into account invalid/null entries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment