New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all shadow style properties #1758

Closed
maxkfranz opened this Issue Mar 27, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@maxkfranz
Member

maxkfranz commented Mar 27, 2017

It is not possible to properly support shadow properties. The canvas does not take scaling into effect. The workaround to increase the blur radius with the zoom level can not work for image exporting. The shadow blur also doesn't correspond to a size in pixels, so it's not possible to use it reliably with current and future performance enhancements.

The following properties are removed:

  • shadow-blur
  • shadow-color
  • shadow-opacity
  • shadow-offset-x
  • shadow-offset-y
  • text-shadow-blur
  • text-shadow-color
  • text-shadow-opacity
  • text-shadow-offset-x
  • text-shadow-offset-y

Shadows can be recreated with the planned ghost style #1197. The ghost style can not support blurring, however.

@maxkfranz maxkfranz added this to the 3.0.0 milestone Mar 27, 2017

@maxkfranz maxkfranz closed this Mar 27, 2017

d2fong added a commit to d2fong/cytoscape.js that referenced this issue Mar 31, 2017

maxkfranz added a commit that referenced this issue Mar 31, 2017

maxkfranz added a commit that referenced this issue Mar 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment