New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `data` parameters in `.on()` etc #1764

Closed
maxkfranz opened this Issue Mar 31, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@maxkfranz
Member

maxkfranz commented Mar 31, 2017

Listener functions like .on() have a data parameter in 2.x, e.g. node.on('tap', { foo: 'bar' }, function(){ /* ... */ }). In order to keep events lean and as performant as possible, this feature will not exist in 3.x.

@maxkfranz maxkfranz added this to the 3.0.0 milestone Mar 31, 2017

@maxkfranz

This comment has been minimized.

Show comment
Hide comment
@maxkfranz
Member

maxkfranz commented Apr 11, 2017

Ref 7565b51

@maxkfranz maxkfranz closed this Apr 11, 2017

@KonradHoeffner

This comment has been minimized.

Show comment
Hide comment
@KonradHoeffner

KonradHoeffner May 9, 2017

The link that should send the user here from the blog post http://blog.js.cytoscape.org/2017/04/11/3.0.0-release/#summary-of-changes sends the user to the non existing URL http://blog.js.cytoscape.org/2017/04/11/3.0.0-release/(https://github.com/cytoscape/cytoscape.js/issues/1764) instead (hope this is the right place to report that).

KonradHoeffner commented May 9, 2017

The link that should send the user here from the blog post http://blog.js.cytoscape.org/2017/04/11/3.0.0-release/#summary-of-changes sends the user to the non existing URL http://blog.js.cytoscape.org/2017/04/11/3.0.0-release/(https://github.com/cytoscape/cytoscape.js/issues/1764) instead (hope this is the right place to report that).

@maxkfranz

This comment has been minimized.

Show comment
Hide comment
@maxkfranz

maxkfranz May 9, 2017

Member

@josephst Would you please look into the link issue on your release post?

Member

maxkfranz commented May 9, 2017

@josephst Would you please look into the link issue on your release post?

@josephst

This comment has been minimized.

Show comment
Hide comment
Member

josephst commented May 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment