Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clustering algorithms #1963

Closed
10 tasks done
maxkfranz opened this issue Sep 5, 2017 · 1 comment
Closed
10 tasks done

Add clustering algorithms #1963

maxkfranz opened this issue Sep 5, 2017 · 1 comment
Milestone
3.3.0

Comments

@maxkfranz
Copy link
Member

maxkfranz commented Sep 5, 2017 •
edited
Loading

Merge the following (unpublished to npm) extensions to the main lib:

For each:

  • Review code
    • High-level review for more obvious issues
    • In-depth review
  • Merge source
  • Merge tests
  • Port readme docs to main lib docs
@maxkfranz maxkfranz added this to the 3.3.0 milestone Sep 5, 2017
@maxkfranz maxkfranz reopened this Nov 10, 2017
@maxkfranz
Copy link
Member Author

maxkfranz commented Nov 10, 2017 •
edited
Loading

Fuzzy c-means has an issue that is erratic: https://travis-ci.org/cytoscape/cytoscape.js/jobs/300396692

maxkfranz added a commit that referenced this issue Apr 16, 2018
@maxkfranz
For k-means and fuzzy c-means, add support for sensitivityThreshold #…
ddb5a03 
…1963
maxkfranz added a commit that referenced this issue Apr 16, 2018
@maxkfranz
Rework the fuzzy c-means test that sometimes fails #1963
bd2db11 
- Increase the number of tries to increase reproducibility.
- Simplify the clusters comparison to a human-readable string comparison.
- Increasing the distance between the expected clusters seems to make the issue not reproducible.  Perhaps it's just much less likely.
- The issue seems to stem from cases where the centroids are much different from where the test implicitly expects.  This happens rarely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

No branches or pull requests
1 participant
@maxkfranz