Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array support for event lists in listener functions #2273

Closed
maxkfranz opened this issue Jan 18, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@maxkfranz
Copy link
Member

commented Jan 18, 2019

Issue type

Feature request

Description of new feature

In addition to a space-separated string, it would be nice to accept an array of strings for events in listener functions like eles.emit(events).

Motivation for new feature

  • Performance
  • Useful for internal use (e.g. #1977)

@maxkfranz maxkfranz added this to the 3.4.0 milestone Jan 18, 2019

@maxkfranz maxkfranz self-assigned this Jan 18, 2019

maxkfranz added a commit that referenced this issue Jan 18, 2019

`tapselect` and `tapunselect` events
Events:
 * `tapselect` : when an element is selected by a tap gesture
 * `tapunselect` : when an element is unselected by a tap gesture on another element

Changes:
- Private: Add support for emitting additional events in switch functions (like `ele.select()`)
- Public: Add array support for `emit()`, e.g. `ele.emit(['event1', 'event2', 'event3'])`
- Public: Add new events
- Private: Make `unselect` and `tapunselect` events happen after `tap`.  That order seems to make more sense.

Ref : #1977 #2273

@maxkfranz maxkfranz closed this Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.