Repository navigation
Support multiple values for background-clip #2441
Description
Activity
So, if you approve, I will send PR.
OK, as long as it doesn't break compatibility. I think
multiple: trueproperties allow a single value to be used as an implicit array of length 1, so it should probably be OK.You can check how other bg image properties are used. I think it may be if only one value is specified, then the same value is used for all.
Reacted by Serhii Stotskyi- added a commit that references this issue
on Jun 20, 2019 Done.
Adding an example of how this looks, so it's easier to understand the purpose. I have a regular image which is requested by HTTP (
background-clipis applied to it) and svg image (black circle) which is base64 encoded (background-clipis not applied to it):
- added 2 commits that reference this issue
on Jun 21, 2019 - added a commit that references this issue
on Jun 24, 2019
Issue type
Feature request
Description of new feature
Allow to specify multiple values for
background-clipproperty, so some background images will be clipped and others notMotivation for new feature
I want to render an background image outside the node. Documentation says that I need to disable
background-clipbut this doesn't work my case, well partially.What I want is to specify multiple background images, clip the first image but DON'T clip the 2nd
Additional
I already tried to do this and it works, requires simple changes in 2 places:
cytoscape.js/src/extensions/renderer/canvas/drawing-images.js
Line 28 in 36a3e97
cytoscape.js/src/style/properties.js
Line 49 in d5ff8a0
So, if you approve, I will send PR.