Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Hide edges on viewport animation #2477
Description of new feature
Animating the viewport of very large graphs may be more performant if edges are hidden during the animation.
Motivation for new feature
I have a large graph (~1k nodes and ~6k edges). Visualizing it is quite performant, but animating it isn't at all.
It's possible to do a workaround: you can, before animating, update the style to set edges to
I'm not familiar with this project's codebase, but if someone can confirm that this should give a perf boost in theory, then the change should be as simple as changing this line to check if the graph is animated:
I think that the scope of the proposed feature should be expanded: An option to hide edges on any animation is not sufficient. Maybe it's sufficient for your use-case, but it could cause conflicts in others. For example, a consumer may want to animate one particular edge and hide the other edges.
(1) This feature should not be coupled with
(2) This feature should not be coupled to animation.
One approach would be to allow for manually setting when edges should be hidden. That's more flexible, but it has usability concerns: A consumer could mistakenly use something new
Generally, I'd prefer to remove features like