Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow taxi distance to be specified relative to the target node #2606

Closed
ofir130 opened this issue Jan 23, 2020 · 3 comments
Closed

Allow taxi distance to be specified relative to the target node #2606

ofir130 opened this issue Jan 23, 2020 · 3 comments
Milestone

Comments

@ofir130
Copy link
Contributor

ofir130 commented Jan 23, 2020

Issue type

Feature request

Description of new feature

Enhance taxi edges so that taxi-turn would accept an absolute distance from the target (could be a negative number as currently, positive number is the absolute distance from the source)

{
  selector: 'edge',
  style: {
    'curve-style': 'taxi',
    'taxi-direction': 'rightward',
    'taxi-turn': '-15px', // negative numbers used to denote distance from target
  }
}

www draw io_

  • red line is the current implementation while the dotted line is how I wished it would render

Motivation for new feature

Have more control over the edges rendering

@maxkfranz
Copy link
Member

This sounds like an interesting feature. Would you be interested in making a pull request for it? I could direct you towards the relevant files and functions.

@ofir130
Copy link
Contributor Author

ofir130 commented Jan 26, 2020

Sure, thanks

@herzaso
Copy link

herzaso commented Jan 26, 2020

#2612

@maxkfranz maxkfranz added this to the 3.14.0 milestone Feb 3, 2020
@maxkfranz maxkfranz changed the title taxi edges enhancement Allow taxt distance to be specified relative to the target node Feb 3, 2020
@maxkfranz maxkfranz changed the title Allow taxt distance to be specified relative to the target node Allow taxi distance to be specified relative to the target node Feb 3, 2020
maxkfranz added a commit that referenced this issue May 29, 2020
The PR for #2606 treats negative turn values as a special case, and some edge cases are not taken into account, e.g. `downward` works but `vertical` does not.  This change unifies the approach to simplify things:  All routing is considered from the source side.  A negative value is just converted into the corresponding positive value.

Refs. : `vertical` or `horizontal` taxi edges are treated as `downward` or `rightward` #2690
maxkfranz added a commit that referenced this issue May 29, 2020
The PR for #2606 treats negative turn values as a special case, and some edge cases are not taken into account, e.g. `downward` works but `vertical` does not.  This change unifies the approach to simplify things:  All routing is considered from the source side.  A negative value is just converted into the corresponding positive value.

Refs. : `vertical` or `horizontal` taxi edges are treated as `downward` or `rightward` #2690
maxkfranz added a commit that referenced this issue May 29, 2020
The PR for #2606 treats negative turn values as a special case, and some edge cases are not taken into account, e.g. `downward` works but `vertical` does not.  This change unifies the approach to simplify things:  All routing is considered from the source side.  A negative value is just converted into the corresponding positive value.

Refs. : Backport 3.14.x : `vertical` or `horizontal` taxi edges are treated as `downward` or `rightward` #2699 #2690
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants