Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Basic convert to esm with only default exports #2084
Some questions re. next steps:
(1) Should we be specifying 'module' in package.json? http://2ality.com/2017/07/npm-packages-via-babel.html
(2) Does Rollup support everything we're currently doing with Webpack in the webpack.config.js and the package.json?
referenced this pull request
Apr 12, 2018
Re (2), we need:
(a) Watch support : --watch via CLI: https://rollupjs.org/guide/en#command-line-flags
(b) Inline source maps toggled on/off via config file: https://rollupjs.org/guide/en#output-sourcemap-m-sourcemap
(c) A way to minify with Uglify and toggle it on/off with an env var in the config file: Not sure if this is possible. We could just pipe the output to uglify, but then Windows users can no longer build. For myself, that's not a problem but it might discourage Windows users from contributing to the lib.
(d) Babel support: https://rollupjs.org/guide/en#babel
(e) Making a UMD build that supports external refs to dependencies. Not sure if this is supported.
(f) Bundling dependencies from npm that aren't ES modules: It looks like a plugin does this https://rollupjs.org/guide/en#npm-packages
(g) Something analogous to EnvironmentPlugin from Webpack : Not sure if this exists