Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document `cy.destroyed()` #2382

Merged
merged 2 commits into from May 7, 2019

Conversation

Projects
None yet
2 participants
@josejulio
Copy link
Contributor

commented May 3, 2019

No description provided.

@maxkfranz

This comment has been minimized.

Copy link
Member

commented May 7, 2019

This function wasn't intended for public consumption. It's not very consistent with the names of other functions -- they don't use isSomething(), only something(). I think it would be OK to make this public but only if we rename the function to destroyed().

@josejulio

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

This function wasn't intended for public consumption. It's not very consistent with the names of other functions -- they don't use isSomething(), only something(). I think it would be OK to make this public but only if we rename the function to destroyed().

Sure, I'll do that.

@maxkfranz maxkfranz added this to the 3.7.0 milestone May 7, 2019

@maxkfranz maxkfranz merged commit 4e4e1d7 into cytoscape:unstable May 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxkfranz maxkfranz changed the title Document isDestroyed method Document `cy.destroyed()` May 7, 2019

@josejulio josejulio deleted the josejulio:document-is-destroyed branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.