Skip to content

Conversation

@r-ba
Copy link
Contributor

@r-ba r-ba commented Oct 20, 2019

This pull request adds Hierholzer's algorithm as proposed in issue #2186 (recently closed, presumably due to inactivity). In particular, it can find Eulerian trails and cycles in both directed and undirected multigraphs should they exist.

For the sake of transparency, it should be known that I am new to the PR game and as such am anticipating potentially extensive feedback for this contribution, although I've attempted to do my due diligence.

@maxkfranz maxkfranz self-requested a review October 21, 2019 13:25
@maxkfranz
Copy link
Member

Thanks for the PR. It looks good at first glance, and I'll review it more thoroughly within the next few days.

My only comment for now is that you should add yourself to the list of contributors in package.json, as this PR is a significant contribution and you should be credited.

@r-ba
Copy link
Contributor Author

r-ba commented Oct 21, 2019

Sounds great, looking forward to it.

@maxkfranz maxkfranz added this to the 3.12.0 milestone Oct 24, 2019
@maxkfranz maxkfranz merged commit d78a6b4 into cytoscape:unstable Oct 24, 2019
@maxkfranz
Copy link
Member

I've merged everything in. Thanks for the PR!

@r-ba r-ba deleted the hierholzer branch November 15, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants