Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTT metrics should use seconds, not milliseconds #16

Closed
tdabasinskas opened this issue Feb 5, 2019 · 0 comments · Fixed by #45
Closed

RTT metrics should use seconds, not milliseconds #16

tdabasinskas opened this issue Feb 5, 2019 · 0 comments · Fixed by #45

Comments

@tdabasinskas
Copy link
Contributor

tdabasinskas commented Feb 5, 2019 •
edited
Loading

Hello,

To follow the official Prometheus guidelines, as well as comments from Prometheus developers, we should be using seconds as the unit for all ping_rtt metrics (e.g. ping_rtt_best_seconds instead of ping_rtt_best_ms).

I can help with PR if needed.
@tdabasinskas tdabasinskas mentioned this issue Feb 6, 2019
Closed
@tdabasinskas tdabasinskas changed the title RTT metrics should use seconds, not miliseconds RTT metrics should use seconds, not milliseconds Apr 1, 2019
dmke added a commit to digineo/ping_exporter that referenced this issue Mar 18, 2021
@dmke
metrics: allow for best pratices
cc67212 
To follow the official Prometheus guidelines [1], as well
as comments from Prometheus developers [2], we should be
using seconds as the unit for all ping_rtt metrics (e.g.
`ping_rtt_best_seconds` instead of `ping_rtt_best_ms`).

This adds a flag `--metrics.rttunits=s`, to allow the user
to follow those best practices.

To keep upgrading users from tripping over this change, the
default units will remain millis.

[1]: https://prometheus.io/docs/practices/naming/#base-units
[2]: https://www.robustperception.io/who-wants-seconds

Fixes: czerwonk#16
@dmke dmke mentioned this issue Mar 18, 2021
Merged
dmke added a commit to digineo/ping_exporter that referenced this issue Mar 18, 2021
@dmke
metrics: allow for best practices
d3c8138 
To follow the official Prometheus guidelines [1], as well
as comments from Prometheus developers [2], we should be
using seconds as the unit for all ping_rtt metrics (e.g.
`ping_rtt_best_seconds` instead of `ping_rtt_best_ms`).

This adds a flag `--metrics.rttunit=s`, to allow the user
to follow those best practices.

To keep upgrading users from tripping over this change, the
default units will remain millis.

[1]: https://prometheus.io/docs/practices/naming/#base-units
[2]: https://www.robustperception.io/who-wants-seconds

Fixes: czerwonk#16
dmke added a commit to digineo/ping_exporter that referenced this issue Mar 19, 2021
@dmke
metrics: allow for best practices
92f0c72 
To follow the official Prometheus guidelines [1], as well
as comments from Prometheus developers [2], we should be
using seconds as the unit for all ping_rtt metrics (e.g.
`ping_rtt_best_seconds` instead of `ping_rtt_best_ms`).

This adds a flag `--metrics.rttunit=s`, to allow the user
to follow those best practices.

To keep upgrading users from tripping over this change, the
default units will remain millis.

[1]: https://prometheus.io/docs/practices/naming/#base-units
[2]: https://www.robustperception.io/who-wants-seconds

Fixes: czerwonk#16
Adphi pushed a commit to partitio/ping_exporter that referenced this issue Mar 22, 2021
@dmke @Adphi
metrics: allow for best practices
bab8177 
To follow the official Prometheus guidelines [1], as well
as comments from Prometheus developers [2], we should be
using seconds as the unit for all ping_rtt metrics (e.g.
`ping_rtt_best_seconds` instead of `ping_rtt_best_ms`).

This adds a flag `--metrics.rttunit=s`, to allow the user
to follow those best practices.

To keep upgrading users from tripping over this change, the
default units will remain millis.

[1]: https://prometheus.io/docs/practices/naming/#base-units
[2]: https://www.robustperception.io/who-wants-seconds

Fixes: czerwonk#16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

metrics: allow for best practices digineo/ping_exporter
1 participant
@tdabasinskas