New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: tag a new release with Go modules support ? #205

Closed
sbinet opened this Issue Aug 2, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@sbinet
Collaborator

sbinet commented Aug 2, 2018

now that #204 is in, cznic/ql has (initial) support for Go modules.

do you think we could tag it (v1.2.0? v1.1.1?) so go mod tidy would pick it up in downstream clients?

@cznic

This comment has been minimized.

Show comment
Hide comment
@cznic

cznic Aug 2, 2018

Owner

So far I've never used git tags nor Go modules and I have insufficient knowledge about both of that to answer your question.

I think you know what's the best to do in this case and you're a trusted developer by many, me included.

Would you mind to take care of this on your own? I hope to learn from the steps you will take ;-)

Partially related: You've contributed to this project but I forgot to ask you to also add yourself to the AUTHORS and/or CONTRIBUTORS files. Please do so, thank you.

Owner

cznic commented Aug 2, 2018

So far I've never used git tags nor Go modules and I have insufficient knowledge about both of that to answer your question.

I think you know what's the best to do in this case and you're a trusted developer by many, me included.

Would you mind to take care of this on your own? I hope to learn from the steps you will take ;-)

Partially related: You've contributed to this project but I forgot to ask you to also add yourself to the AUTHORS and/or CONTRIBUTORS files. Please do so, thank you.

@sbinet

This comment has been minimized.

Show comment
Hide comment
@sbinet

sbinet Aug 2, 2018

Collaborator

thanks for the vote of confidence :)

I'll add myself to the CONTRIBUTORS file and then run git tag v1.2.0.

I think that's all there is to it. (oops, I'll also add a little blurb to doc.go.)
I am learning also the best practices for Go with modules...

Collaborator

sbinet commented Aug 2, 2018

thanks for the vote of confidence :)

I'll add myself to the CONTRIBUTORS file and then run git tag v1.2.0.

I think that's all there is to it. (oops, I'll also add a little blurb to doc.go.)
I am learning also the best practices for Go with modules...

@sbinet sbinet closed this in 47bf73c Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment