New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CEF 3.3202.1692.g18a939d #10

Merged
merged 1 commit into from Dec 6, 2017

Conversation

Projects
None yet
2 participants
@fenryxo
Contributor

fenryxo commented Dec 5, 2017

No description provided.

@cztomczak

This comment has been minimized.

Show comment
Hide comment
@cztomczak

cztomczak Dec 5, 2017

Owner
  1. Only the include/ directory was updated? There were no changes required to capi/ root directory?
  2. Looks like you have updated include/ directory with include/ directory from Linux binary distribution. You should have used include/ directory from the CEF repository from bitbucket at appropriate revision. Windows and Mac specific files are missing.
  3. After point 2) is fixed see also the notes on "cef_version_win.h" and "cef_version_linux.h"
  4. Have you tested it on Windows?
  5. Patch for GCC compiler on Windows is no more required, so README.md should be updated
Owner

cztomczak commented Dec 5, 2017

  1. Only the include/ directory was updated? There were no changes required to capi/ root directory?
  2. Looks like you have updated include/ directory with include/ directory from Linux binary distribution. You should have used include/ directory from the CEF repository from bitbucket at appropriate revision. Windows and Mac specific files are missing.
  3. After point 2) is fixed see also the notes on "cef_version_win.h" and "cef_version_linux.h"
  4. Have you tested it on Windows?
  5. Patch for GCC compiler on Windows is no more required, so README.md should be updated
@cztomczak

This comment has been minimized.

Show comment
Hide comment
@cztomczak

cztomczak Dec 5, 2017

Owner
  1. You've added C++ header files which are unnecessary and should be deleted (files in include/, include/views/ and include/wrapper/)
Owner

cztomczak commented Dec 5, 2017

  1. You've added C++ header files which are unnecessary and should be deleted (files in include/, include/views/ and include/wrapper/)
@fenryxo

This comment has been minimized.

Show comment
Hide comment
@fenryxo

fenryxo Dec 5, 2017

Contributor
  1. It builds and runs without any changes in the capi/ root directory.
  2. Fixed: Copied files from CEF git 18a939d.
  3. Fixed: Copied version headers from win & linux binary distributions.
  4. I have no opportunity to test CEF on Windows.
  5. Readme updated.
  6. Fixed: C++ headers removed.
Contributor

fenryxo commented Dec 5, 2017

  1. It builds and runs without any changes in the capi/ root directory.
  2. Fixed: Copied files from CEF git 18a939d.
  3. Fixed: Copied version headers from win & linux binary distributions.
  4. I have no opportunity to test CEF on Windows.
  5. Readme updated.
  6. Fixed: C++ headers removed.
@cztomczak

This comment has been minimized.

Show comment
Hide comment
@cztomczak

cztomczak Dec 5, 2017

Owner

Looks good now. Only the Compatibility section for Windows needs to be updated in README.md.

Owner

cztomczak commented Dec 5, 2017

Looks good now. Only the Compatibility section for Windows needs to be updated in README.md.

@fenryxo

This comment has been minimized.

Show comment
Hide comment
@fenryxo

fenryxo Dec 5, 2017

Contributor

It would be better to test it on Windows before claiming it's a tested configuration.

Contributor

fenryxo commented Dec 5, 2017

It would be better to test it on Windows before claiming it's a tested configuration.

@cztomczak

This comment has been minimized.

Show comment
Hide comment
@cztomczak

cztomczak Dec 5, 2017

Owner

It works on Windows. Only seeing some warnings in console, but everything seems to be working fine. Logs:

[1205/194447.310:WARNING:PushPullFIFO.cpp(182)] PushPullFIFO: underflow while pulling (underflowCount=1, avail
ableFrames=0, requestedFrames=448, fifoLength=8192)
[1205/194447.370:WARNING:angle_platform_impl.cc(51)] rx::HLSLCompiler::compileToBinary(228):
C:\fakepath(71,11-35): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally hand
le negative values if you expect them
C:\fakepath(95,11-35): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally hand
le negative values if you expect them
Owner

cztomczak commented Dec 5, 2017

It works on Windows. Only seeing some warnings in console, but everything seems to be working fine. Logs:

[1205/194447.310:WARNING:PushPullFIFO.cpp(182)] PushPullFIFO: underflow while pulling (underflowCount=1, avail
ableFrames=0, requestedFrames=448, fifoLength=8192)
[1205/194447.370:WARNING:angle_platform_impl.cc(51)] rx::HLSLCompiler::compileToBinary(228):
C:\fakepath(71,11-35): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally hand
le negative values if you expect them
C:\fakepath(95,11-35): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally hand
le negative values if you expect them
@fenryxo

This comment has been minimized.

Show comment
Hide comment
@fenryxo

fenryxo Dec 5, 2017

Contributor

Great 👍 Which Windows and compiler version should I update the readme with?

Contributor

fenryxo commented Dec 5, 2017

Great 👍 Which Windows and compiler version should I update the readme with?

@cztomczak

This comment has been minimized.

Show comment
Hide comment
@cztomczak

cztomczak Dec 6, 2017

Owner

Just update the revision.

Owner

cztomczak commented Dec 6, 2017

Just update the revision.

@fenryxo

This comment has been minimized.

Show comment
Hide comment
@fenryxo

fenryxo Dec 6, 2017

Contributor

Done.

Contributor

fenryxo commented Dec 6, 2017

Done.

@cztomczak

This comment has been minimized.

Show comment
Hide comment
@cztomczak

cztomczak Dec 6, 2017

Owner

cef_version_win.h needs updating as well to match.

Owner

cztomczak commented Dec 6, 2017

cef_version_win.h needs updating as well to match.

Update to CEF 3.3202.1692.g18a939d
Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
@fenryxo

This comment has been minimized.

Show comment
Hide comment
@fenryxo

fenryxo Dec 6, 2017

Contributor

Hm, it seems that the Windows binary distribution lagged behind the Linux one when I downloaded them. Corrected.

Contributor

fenryxo commented Dec 6, 2017

Hm, it seems that the Windows binary distribution lagged behind the Linux one when I downloaded them. Corrected.

@cztomczak cztomczak merged commit c444fcf into cztomczak:master Dec 6, 2017

@cztomczak

This comment has been minimized.

Show comment
Hide comment
@cztomczak

cztomczak Dec 6, 2017

Owner

Thanks, merged.

Owner

cztomczak commented Dec 6, 2017

Thanks, merged.

@cztomczak

This comment has been minimized.

Show comment
Hide comment
@cztomczak

cztomczak Dec 6, 2017

Owner

Add yourself to the Authors file in next PR.

Owner

cztomczak commented Dec 6, 2017

Add yourself to the Authors file in next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment