MSP Alarm Support #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| uint8_t buf[0]; | ||
| struct { | ||
| uint8_t state; | ||
| uint8_t msg[MAX_ALARM_LEN]; |
There was a problem hiding this comment.
Should be char rather than uint8_t?
This is an extension created in MWOSD here: ShikOfTheRa/scarab-osd#141
|
jenkins, test this please |
1 similar comment
|
jenkins, test this please |
|
Also, since it was sort of happening at the same time, boot message as an alarm within the first ~7s of receiving alarms requests.
|
Sorry, PicoC incompatibility. Fixed. |
|
;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change creates a new MSP command that allows the peer (e.g. OSD) to ask for alarms from the flight controller. The alarm message includes severity and a message. In its current form, only one alarm is sent (fairly arbitrarily, other than severity taking precedence). Also, as a special and very useful case, boot reason is considered a warning from the perspective of the MSP code for the first few seconds. It might be worth generally considering that an alarm which would allow this special case code to be removed.
This has been very useful to me in showing both regular alarms (e.g. I let someone fly my sparky yesterday and saw 'MAN:NO RX' flashing on the screen because OpenTX companion turned off the radio for that profile) as well as boot reasons (saw watchdog firing in flight instead of mysteriously crashing).
STATUS: Flown a lot. Used to diagnose bugs.
CAVEAT: MWOSD side is not yet accepted (waiting for @ShikOfTheRa in ShikOfTheRa/scarab-osd#141)