New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Embed on site #125

Open
XpodX opened this Issue Jun 1, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@XpodX

XpodX commented Jun 1, 2016

It would be so nice to have a embed d3planner on your web site.
I Found this one but its not complete at all (no items no rolls etc).
http://diablo3.judgehype.com/build/23951/

<iframe src="http://diablo3.judgehype.com/build-embed/23951/" name="D3BuilderFrame" id="D3BuilderFrame" width="645" height="775" style="border:0;background-color:#131313"></iframe>

I like your work. Keep it up.

@d07RiV

This comment has been minimized.

Show comment
Hide comment
@d07RiV

d07RiV Jun 6, 2016

Owner

Sounds interesting, might require a lot of work though as it would have to re-use a large portion of the code.

Owner

d07RiV commented Jun 6, 2016

Sounds interesting, might require a lot of work though as it would have to re-use a large portion of the code.

@jlhall

This comment has been minimized.

Show comment
Hide comment
@jlhall

jlhall Nov 1, 2016

@d07RiV I haven't looked a lot yet through this project but have you considered a completely decoupled app? You already have a lot of the pure data publicly exposed at different routes: /skills etc. But I imagine reworking all the major code to be hosted as purely an API would be extremely time consuming. Not to mention the number of requests...yikes

jlhall commented Nov 1, 2016

@d07RiV I haven't looked a lot yet through this project but have you considered a completely decoupled app? You already have a lot of the pure data publicly exposed at different routes: /skills etc. But I imagine reworking all the major code to be hosted as purely an API would be extremely time consuming. Not to mention the number of requests...yikes

@d07RiV

This comment has been minimized.

Show comment
Hide comment
@d07RiV

d07RiV Nov 1, 2016

Owner

You mean for the iframe thing? There's almost no backend code, all the work is done via javascript so there isn't much to turn into an API.

Owner

d07RiV commented Nov 1, 2016

You mean for the iframe thing? There's almost no backend code, all the work is done via javascript so there isn't much to turn into an API.

@d07RiV d07RiV added the backlog label Nov 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment