Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not reinstall with @28 --with-native-comp --with-modern-icon #321

Closed
3 tasks done
aaronjensen opened this issue Mar 9, 2021 · 6 comments
Closed
3 tasks done
Assignees

Comments

@aaronjensen
Copy link
Contributor

Please make sure to follow these steps (and mark the checkboxes):

  • run brew update and try to reproduce the issue again
  • run brew doctor, fix all issues and try to reproduce your issue again
  • run brew config and brew doctor and include their output

What you were trying to do

brew reinstall emas-plus@28

==> Reinstalling d12frosted/emacs-plus/emacs-plus@28 --with-native-comp --with-modern-icon

What happened (include command output)

$ brew reinstall emacs-plus@28

I'm trying again with a fresh install (not reinstall), I'll report back if anything is different.

Command output

==> Downloading https://raw.githubusercontent.com/d12frosted/homebrew-emacs-plus/master/patches/emacs-28/fix-window-role.patch
Already downloaded: /Users/aaronjensen/Library/Caches/Homebrew/downloads/fe10dba71a5a9f8fef6f4534268970b2b0ae0f941e515daed7ae88465083c287--fix-window-role.patch
==> Downloading https://raw.githubusercontent.com/d12frosted/homebrew-emacs-plus/master/patches/emacs-28/system-appearance.patch
Already downloaded: /Users/aaronjensen/Library/Caches/Homebrew/downloads/aaa0da80d33eac9e551adf7faf404e565c71e86c02ea4659200474fd6d899f5a--system-appearance.patch
==> Cloning https://github.com/emacs-mirror/emacs.git
Updating /Users/aaronjensen/Library/Caches/Homebrew/emacs-plus@28--git
==> Checking out branch master
Already on 'master'
Your branch is up to date with 'origin/master'.
HEAD is now at 40d8f83 smerge-vc-next-conflict: Move to conflict markers more reliably
==> Reinstalling d12frosted/emacs-plus/emacs-plus@28 --with-native-comp --with-modern-icon
==> Patching
==> Applying fix-window-role.patch
patching file src/nsterm.m
Hunk #1 succeeded at 8904 (offset 136 lines).
==> Applying system-appearance.patch
patching file src/frame.h
patching file src/nsfns.m
Hunk #1 succeeded at 1277 (offset 24 lines).
patching file src/nsterm.m
Hunk #1 succeeded at 2197 (offset 3 lines).
Hunk #2 succeeded at 5693 (offset -58 lines).
Hunk #3 succeeded at 5939 (offset -58 lines).
Hunk #4 succeeded at 5989 (offset -58 lines).
Hunk #5 succeeded at 6215 (offset -58 lines).
Hunk #6 succeeded at 9235 (offset 103 lines).
Hunk #7 succeeded at 10321 (offset 307 lines).
==> ImageMagick PKG_CONFIG_PATH:
/usr/local/opt/imagemagick/lib/pkgconfig
==> ./autogen.sh
==> ./configure --enable-locallisppath=/usr/local/share/emacs/site-lisp --infodir=/usr/local/Cellar/emacs-plus@28/28.0.50/share/info/emacs --prefix=/usr/local/Cellar/e
==> make
==> make install
Error: An exception occurred within a child process:
Errno::ENOENT: No such file or directory - native-lisp

Output of brew config

$ brew config
HOMEBREW_VERSION: 3.0.4
ORIGIN: https://github.com/Homebrew/brew
HEAD: ee52b19179d056f3dd2fdf9c52214d3d51dbb9d9
Last commit: 7 days ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 50db2638cd8b16d577c1919398176458cdbbb95c
Core tap last commit: 32 minutes ago
Core tap branch: master
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CASK_OPTS: ["--appdir=/Applications"]
HOMEBREW_EDITOR: e
HOMEBREW_MAKE_JOBS: 16
HOMEBREW_NO_AUTO_UPDATE: set
HOMEBREW_TEMP: /var/tmp
Homebrew Ruby: 2.6.3 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: 16-core 64-bit kabylake
Clang: 12.0 build 1200
Git: 2.30.1 => /usr/local/bin/git
Curl: 7.64.1 => /usr/bin/curl
macOS: 11.2.3-x86_64
CLT: 12.4.0.0.1.1610135815
Xcode: 12.4

Output of brew doctor

$ brew doctor
Your system is ready to brew.
@aaronjensen
Copy link
Contributor Author

It built fine with a regular install. The problem only exhibits on a reinstall, it seems.

@d12frosted
Copy link
Owner

I'm trying again with a fresh install (not reinstall), I'll report back if anything is different.

Yes, please try 😸 Because reinstall in brew is not the same as uninstall + install.

@d12frosted
Copy link
Owner

d12frosted commented Mar 9, 2021

It built fine with a regular install. The problem only exhibits on a reinstall, it seems.

Ah, you already have an answer 😸

The question about reinstall occured multiple times. I even added a section to readme saying that one should not use reinstall. Since it's "expected", closing the issue.

P. S. Glad it actually worked after after uninstall 😸

Update ah, the readme says about new options scenario. I will update to say that reinstall should not be used even if you want the same options. brew reinstall only works if you initially installed without any options. They don't want to support them 😸

@d12frosted
Copy link
Owner

@aaronjensen Found the relevant conversation #218

@d12frosted
Copy link
Owner

As a follow up - 01973b0

@aaronjensen
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants