Please sign in to comment.
[Fix] Dont pass invalid keys to ArrayData::remove
Summary: Variant::remove(CVarRef) could end up passing a "null" key to ArrayData::remove if given an invalid key (array or object). In the DEBUG build, this asserted, and in the release build it removed the element with key 0. The new test case produced incorrect results in the release build, and asserted in the debug build. Task ID: #768801 Blame Rev: Reviewers: kma qigao CC: Test Plan: fast_tests slow_tests (new test case added). Revert Plan: Tags: Platform Impact (PUBLIC): Differential Revision: 347370
- Loading branch information...
Showing with 10 additions and 1 deletion.